Skip to content

fix settings update method not called with await #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wenxi-zeng merged 1 commit into from
Mar 4, 2024
Merged

fix settings update method not called with await #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Analytics-CSharp/Segment/Analytics/Settings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public struct Settings

public partial class Analytics
{
internal async void Update(Settings settings) {
internal async Task Update(Settings settings) {
System systemState = await Store.CurrentState<System>();
HashSet<int> initializedPlugins = new HashSet<int>();
Timeline.Apply(plugin => {
Expand Down Expand Up @@ -49,7 +49,7 @@ await Scope.WithContext(NetworkIODispatcher, async () =>
settings = systemState._settings;
}

Update(settings.Value);
await Update(settings.Value);
await Store.Dispatch<System.ToggleRunningAction, System>(new System.ToggleRunningAction(true));
}
}
Expand Down