Fixing event pipeline provider type#127
Merged
Merged
Conversation
… test to validate they're getting used
didiergarcia
previously approved these changes
Feb 28, 2025
There was a problem hiding this comment.
PR Overview
This PR updates the event pipeline provider configuration to use a custom provider interface and validates its usage through new tests.
- Updates Configuration.cs to accept IEventPipelineProvider instead of a concrete type.
- Introduces new tests validating both standard and custom event pipeline provider implementations.
Reviewed Changes
| File | Description |
|---|---|
| Tests/Utilities/EventPipelineTest.cs | Adds tests to validate that the event pipeline providers, both standard and custom, are used in the configuration. |
| Analytics-CSharp/Segment/Analytics/Configuration.cs | Changes the parameter type for event pipeline provider to IEventPipelineProvider, supporting pluggable custom implementations. |
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
Tests/Utilities/EventPipelineTest.cs:225
- [nitpick] Consider adding an assertion to verify that the event pipeline provider is actively processing or modifying events, to ensure complete test coverage of the provider integration.
analytics.Track("test");
Tests/Utilities/EventPipelineTest.cs:241
- [nitpick] Consider asserting the exception message or adding further validation to ensure that the NotImplementedException is raised for the expected reason, if a specific message is available.
Assert.Throws<NotImplementedException>(() => {
wenxi-zeng
previously approved these changes
Mar 4, 2025
wenxi-zeng
approved these changes
Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom pipelines can now be set, plus a test to validate they are used.