Provider pattern for EventPipleline and new SyncEventPipeline for synchronous flush#101
Merged
Merged
Conversation
wenxi-zeng
reviewed
Apr 29, 2024
wenxi-zeng
approved these changes
Apr 30, 2024
wenxi-zeng
left a comment
wenxi-zeng
left a comment
Contributor
There was a problem hiding this comment.
LGTM. the idea of reusing the tests for different implementations of the same interface is super!
…ancellation tokens, and is not imitating.
wenxi-zeng
approved these changes
Apr 30, 2024
Contributor
Author
|
resolves #74 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.