Correct missing highlighting of dead code#751
Merged
sebastianbergmann merged 1 commit intosebastianbergmann:masterfrom May 19, 2020
Merged
Correct missing highlighting of dead code#751sebastianbergmann merged 1 commit intosebastianbergmann:masterfrom
sebastianbergmann merged 1 commit intosebastianbergmann:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #751 +/- ##
=========================================
Coverage 83.87% 83.87%
Complexity 846 846
=========================================
Files 37 37
Lines 2480 2480
=========================================
Hits 2080 2080
Misses 400 400 Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @sebastianbergmann
I've noticed that dead code detection does not seem to be working correctly in the HTML report: the legend indicates that it should be highlighted in yellow but it currently outputs in white.
The HTML itself is correct, just needs a small tweak to the CSS.
Before
After
