Skip to content

Prioritize pcov above xdebug#709

Merged
sebastianbergmann merged 1 commit intosebastianbergmann:masterfrom
Zlender:pcov
Nov 15, 2019
Merged

Prioritize pcov above xdebug#709
sebastianbergmann merged 1 commit intosebastianbergmann:masterfrom
Zlender:pcov

Conversation

@Zlender
Copy link
Copy Markdown

@Zlender Zlender commented Nov 15, 2019

Pcov is a much faster code coverage driver and in situtation where both Xdebug and pcov are installed it should be used above xdebug in my opinion.

I've tested with a codebase with some 40k lines of code and 4000 tests.

Config Time Memory
No coverage 20s 280MB
Pcov only 42s 390MB
Pcov and xdebug with patch 1.44min 410MB
Pcov and xdebug without patch 8min 360MB

It is a change in behavior though as pcov and xdebug might collect different coverage information

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 15, 2019

Codecov Report

Merging #709 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #709   +/-   ##
=========================================
  Coverage     85.13%   85.13%           
  Complexity      812      812           
=========================================
  Files            32       32           
  Lines          2476     2476           
=========================================
  Hits           2108     2108           
  Misses          368      368
Impacted Files Coverage Δ Complexity Δ
src/CodeCoverage.php 73.13% <100%> (ø) 181 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b85a920...a908b4c. Read the comment docs.

@sebastianbergmann
Copy link
Copy Markdown
Owner

Thank you for your contribution. I appreciate the time you invested in preparing this pull request. However, I have decided not to merge it as I do not think that there is an issue to solve here: simply do not load Xdebug and PCOV at the same time.

@sebastianbergmann sebastianbergmann merged commit 8198f74 into sebastianbergmann:master Nov 15, 2019
@sebastianbergmann
Copy link
Copy Markdown
Owner

Changed my mind, thank you for your contribution.

@Zlender
Copy link
Copy Markdown
Author

Zlender commented Nov 15, 2019

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants