WIP: Add webview, tidy up & simplify the plugin source code, #94#162
Closed
olilarkin wants to merge 22 commits into
Closed
WIP: Add webview, tidy up & simplify the plugin source code, #94#162olilarkin wants to merge 22 commits into
olilarkin wants to merge 22 commits into
Conversation
Contributor
|
@olilarkin - regarding this commit: 63763be - are the project files generated in some way, or is this done manually? |
Contributor
Author
|
Unfortunately, at the moment, it's manual, but we have seen cmake support on a branch which I hope to merge soon |
Contributor
|
Cmake support would be great - right now it requires dev intervention on each platform to add/remove/rename plugin code files. |
Owner
|
Just checking in since this is a draft. Is it close to ready? Otherwise I may proceed to merge a few of the other PRs. But I'll hang onto them for a bit if this is coming soon & we can avoid some potential merge conflicts (I'm happy to deal w/ them on mine instead) |
Contributor
Author
|
please proceed, i need to redo this PR anyway. |
Owner
|
Thanks for letting me know. I may steal some pieces anyways like the formatting :) |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Steve,
I started this branch to show @d3NNEb how to add a webview properly to the iPlug2 project, however when doing so I realised the NAM plug-in source code has ballooned and become very unwieldy. There are things that can be done much more cleanly in iPlug2.
Unfortunately I don't have time to make very atomic PRs to fix all the problems, but I wondered if you would consider a PR like this, trusting me, without being arrogant, that I know what I am doing :-). I don't have the time to go through lots of Q&A on the PR, but I absolutely know how to make the code for the plug-in part of the project much cleaner and better, and easier for others to contribute to. If I can do this I will feel much happier about fixing the various bits of iPlug2 that are coming up as issues with the rapidly expanding NAM community!
Oli