Moved pre-warm to DSP and call it in get_dsp()#90
Merged
Conversation
EdwardPayne
added a commit
to EdwardPayne/NeuralAmpModelerReamping
that referenced
this pull request
Dec 30, 2023
* Move pre-warm to DSP and call it in get_dsp() (sdatkinson#90) * Add nam namespace (sdatkinson#93) * Fix tools (sdatkinson#94) * [BREAKING] Remove parametric modeling code (sdatkinson#95) * Get rid of parametric modeling code * Virtual set condition array * Bump version to 0.1.0 --------- Co-authored-by: Mike Oliphant <oliphant@nostatic.org> Co-authored-by: Steven Atkinson <steven@atkinson.mn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a prewarm() method to the DSP base class that gets called from get_dsp().
The default behavior is to process the model over "_prewarm_samples" samples. By default, this is 0 - so nothing happens for LSTM (which is what we want).
WaveNet and ConvNet both set "_prewarm_samples" to the size of the model's receptive field.
@sdatkinson I don't use ConvNet, so I'm not sure I got the receptive field correct - can you make sure to check it?
Resolves #89
Resolves #61