Skip to content

Fix compiler warnings#53

Merged
sdatkinson merged 1 commit into
sdatkinson:mainfrom
mod-audio:fix-warnings
Jun 20, 2023
Merged

Fix compiler warnings#53
sdatkinson merged 1 commit into
sdatkinson:mainfrom
mod-audio:fix-warnings

Conversation

@falkTX

@falkTX falkTX commented Jun 15, 2023

Copy link
Copy Markdown
Contributor

This PR fixes several compiler warnings generated by GCC under Linux.
They are quite a few but related to just 2 issues:

  1. Comparison of signed vs unsigned types (because std::vector<>::size() returns size_t which is unsigned)
  2. C++ class constructors have wrong member initialization order

Signed-off-by: falkTX <falktx@falktx.com>

@sdatkinson sdatkinson left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏻

@sdatkinson sdatkinson merged commit 104685b into sdatkinson:main Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants