Fix minor incompatibilities with clang/g++ build on Linux#50
Merged
Conversation
falkTX
pushed a commit
to mod-audio/NeuralAmpModelerCore
that referenced
this pull request
Jun 15, 2023
synchu
pushed a commit
to synchu/NeuralAmpModelerCore
that referenced
this pull request
Mar 24, 2026
* Loading weights from JSON works. This is a midpoitn commit where we hack `config.json` to be called `model.nam` and get both to work. In the next commit, we move over to picking the config directly and have a stopgap for old-style models. * get_dsp takes path to the config file instead of the directory * Load NAMs by picking a file instead of a directory Inherits the much nicer file browser instead of the directory picker :) * Error message telling users to upgrade directory-style models * More careful loading of weights and better error messages * A few more IR cases * Legacy load button for Macs * Cleaner model and IR load messages * Fix up file SVG, add to VS resources * Initialize mNAMPath and mNAMLegacyPath
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some errors came up when I was building a JUCE project in Linux. So, quick fix.