Add CMake build tools#34
Merged
Merged
Conversation
Closed
Contributor
Author
|
I added a simple model benchmarking tool. It would be great to get this merged - it makes it much easier to experiment with the core code, and gives us build checks on PRs. |
sdatkinson
approved these changes
May 27, 2023
sdatkinson
left a comment
sdatkinson
left a comment
Owner
There was a problem hiding this comment.
Seems good to me.
Thanks for this; excited to get into it more!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR adds a CMake build processes to allow checking buildability as well as creating some tools.
Right now, the only tool is a simple "loadmodel" program, but it is sufficient to test whether the core NAM code compiles.
To enable building, I added the Eigen and json.hpp dependencies to this repo.