[BUGFIX] Eliminate real-time allocations in WaveNet#141
Merged
Conversation
Add some new methods to get it done Not yet RT safe when gating activations are used.
Owner
Author
|
Ugh, I need to get #140 sorted. I'll get that figured out before I release 0.3.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sort-of breaking changes (causing me to bump to 0.3.0):
Reset()callsprewarm(). (This is now ok because it callsSetMaxBufferSize()first, which can handle allocation of model arrays.)mMaxBufferSizedefaults to0instead of512on construction. This is nice and conservative but might break code that was expecting teh mdoel to come "ready to go" out ofget_dsp()(However,Reset()should be called before using the model!)Resolves #49