update nlohmann json to latest to be able to compile NeuralAmpModelerCore with C++20 and also C++23#134
update nlohmann json to latest to be able to compile NeuralAmpModelerCore with C++20 and also C++23#134erikgrahn13 wants to merge 1 commit into
Conversation
|
Looking at the nlohmann/json releases page, I assume that "latest" means 3.11.3.
So this doesn't appear to actually be v3.11.3 (and it's not other versions because there would be diffs on the version stated in the comments.) This is a good idea (thanks for the PR to bring it to my attention), but I might just try out 3.12.0 and use that if everything seems to work. (Feel free to update this PR to do that if you get to it before me. If not I'll note here and close this.) But also, I'd prefer not to use the head of a dev branch, if that's what's going on here that explains the diff above, since that can make it difficult to track down issues if they arise). |
|
Superseded by #152. Thanks! |
In the current state of the main branch of NeuralAmpModelerCore you cannot compile it with C++20 on MacOS. With MSVC it seems to still compile with C++20 but using the XCode toolchain it breaks due to the old version of nlohmann json