Remove nam::DSP::finalize_()#110
Merged
Merged
Conversation
Owner
Author
|
Resolves #99 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Breaking change. Following this, Code calling NAM should not do (e.g.):
and instead just do
model->process(input, output, numFrames);And subclasses shall take care of any preparation for the next call to
processthemselves.Subclasses that don't override nor extend
DSP::finalize_():BaseGainHistoryLSTMSubclasses where some change was needed:
Buffer: This advanced the input buffer. Made an equivalent protected method_advance_input_buffer_()that subclasses can still use.WaveNet: Move_advance_buffers_()inside ofprocess.Subclasses of
Bufferalso needed to be checked:ConvNet: doesn't override, so_advance_input_buffer_()is pulled inside ofprocess()Linear: SameTesting
I checked a render before and after using a typical WaveNet and ensured that they're the same.