NAM file format version bump for A2?

[mikeoliphant]

The example A2 file here:

https://github.com/sdatkinson/NeuralAmpModelerCore/blob/main/example_models/wavenet_a2_max.nam

is still showing "0.5.4" as the file format version number.

I'm assuming this will get bumped when "real" A2 models roll out?

[sdatkinson]

Good catch--thanks.

I feel like I need to re-think that. On one hand, since the old parser would certainly parse the file incorrectly, I think that it should bump to v0.6.0 (or honestly perhaps 1.0.0). On the other hand, I'm having a hard time thinking of a change that wouldn't be ignored. Perhaps things like calibration metadata...

Lmk if you have any opinions; if not, I think I'll say 0.6.0, and I'll update the trainer accordingly once that work gets done.

[mikeoliphant]

0.6.0 seems fine.

[mikeoliphant]

👍

One last detail - the nested "condition_dsp" model of the "wavenet_a2_max.nam" model still has a "0.5.4" version, even though it is A2.

[sdatkinson]

Once again, good catch 🙃 could've sworn I had gotten it.

FWIW I think at least that config wouldn't have ever been touched (somewhat oddly).

Puzzled for a second over why no test had failed including the test that runs that model end to end. Alas.

Got it

[mikeoliphant]

👍