The WaveNet check to make sure there is no "head" element in the json has a couple of problems that are currently canceling each other out under normal circumstances.
This line:
|
const bool with_head = config["head"] == NULL; |
has two problems. First, the logic is reversed, and it looks like it should incorrectly be setting "with_head" to "true" when it is null.
This is currently being compensated for by the fact that having:
"head": null
in the json actually doesn't make config["head"] null - it is rather a json object that references null.
So, everything currently works ok, but the check isn't really doing what it is supposed to do.
The WaveNet check to make sure there is no "head" element in the json has a couple of problems that are currently canceling each other out under normal circumstances.
This line:
NeuralAmpModelerCore/NAM/get_dsp.cpp
Line 175 in 028e648
has two problems. First, the logic is reversed, and it looks like it should incorrectly be setting "with_head" to "true" when it is null.
This is currently being compensated for by the fact that having:
"head": nullin the json actually doesn't make config["head"] null - it is rather a json object that references null.
So, everything currently works ok, but the check isn't really doing what it is supposed to do.