Skip to content

fix: remove unused parameters in co_occurence - #1121

Merged
selmanozleyen merged 8 commits into
scverse:mainfrom
selmanozleyen:fix/co-occurence-unused-params
Mar 11, 2026
Merged

fix: remove unused parameters in co_occurence#1121
selmanozleyen merged 8 commits into
scverse:mainfrom
selmanozleyen:fix/co-occurence-unused-params

Conversation

@selmanozleyen

Copy link
Copy Markdown
Member

fixes: #1110 and #1048 .

n_splits usage was removed here 32789ae

@flying-sheep flying-sheep left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will break code that uses these parameters – sure they are unused, but you could warn first that they do nothing and will be removed, and then remove them later,

@codecov

codecov Bot commented Feb 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.96%. Comparing base (240dcfe) to head (7c4fec7).
⚠️ Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
src/squidpy/_utils.py 72.72% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1121   +/-   ##
=======================================
  Coverage   72.96%   72.96%           
=======================================
  Files          38       38           
  Lines        6484     6496   +12     
  Branches     1151     1153    +2     
=======================================
+ Hits         4731     4740    +9     
- Misses       1270     1272    +2     
- Partials      483      484    +1     
Files with missing lines Coverage Δ
src/squidpy/gr/_ppatterns.py 78.01% <100.00%> (+0.09%) ⬆️
src/squidpy/_utils.py 57.21% <72.72%> (+0.96%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@selmanozleyen
selmanozleyen force-pushed the fix/co-occurence-unused-params branch from 39163ff to 583bdcb Compare February 27, 2026 20:17
@selmanozleyen
selmanozleyen requested a review from ilan-gold March 2, 2026 14:01
@selmanozleyen
selmanozleyen requested review from timtreis and removed request for flying-sheep, ilan-gold and timtreis March 11, 2026 12:26

@timtreis timtreis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@selmanozleyen
selmanozleyen merged commit 17a3b48 into scverse:main Mar 11, 2026
14 checks passed
selmanozleyen added a commit to selmanozleyen/squidpy that referenced this pull request Mar 11, 2026
* remove the params

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* recommit

* update nb

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@durr1602

durr1602 commented Jun 4, 2026

Copy link
Copy Markdown

just a quick question, was there anything else to replace the progress bar? i'm not even sure there was one with the squidpy version I'm testing, but with this new version there doesn't seem to be any sort of log (at least on my end).

@selmanozleyen

Copy link
Copy Markdown
Member Author

It should log something at least looking at "start = logg.info(f"Calculating co-occurrence probabilities for {len(interval)} intervals")". Maybe you should check stderr?

@durr1602

durr1602 commented Jun 8, 2026

Copy link
Copy Markdown

Yes, that's what I'd thought as well.. weird. I'm running a Jupyter notebook in Positron. I've tried both the new Positron notebook editor (which is still under active dev I believe) and the legacy editor, but no output with either. I tried to capture both stdout and stderr using the magic %%capture but both are empty..

I thought I'd just ask, if the issue is not reproducible on your end, it's not that big of a deal. Let me know if you think it warrants opening an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unused parallelization parameters in co_occurrence

4 participants