fix: remove unused parameters in co_occurence - #1121
Conversation
for more information, see https://pre-commit.ci
flying-sheep
left a comment
There was a problem hiding this comment.
this will break code that uses these parameters – sure they are unused, but you could warn first that they do nothing and will be removed, and then remove them later,
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1121 +/- ##
=======================================
Coverage 72.96% 72.96%
=======================================
Files 38 38
Lines 6484 6496 +12
Branches 1151 1153 +2
=======================================
+ Hits 4731 4740 +9
- Misses 1270 1272 +2
- Partials 483 484 +1
🚀 New features to boost your workflow:
|
39163ff to
583bdcb
Compare
* remove the params * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * recommit * update nb --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
|
just a quick question, was there anything else to replace the progress bar? i'm not even sure there was one with the squidpy version I'm testing, but with this new version there doesn't seem to be any sort of log (at least on my end). |
|
It should log something at least looking at "start = logg.info(f"Calculating co-occurrence probabilities for |
|
Yes, that's what I'd thought as well.. weird. I'm running a Jupyter notebook in Positron. I've tried both the new Positron notebook editor (which is still under active dev I believe) and the legacy editor, but no output with either. I tried to capture both stdout and stderr using the magic I thought I'd just ask, if the issue is not reproducible on your end, it's not that big of a deal. Let me know if you think it warrants opening an issue. |
fixes: #1110 and #1048 .
n_splits usage was removed here 32789ae