Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1071 +/- ##
=======================================
Coverage 91.94% 91.94%
=======================================
Files 51 51
Lines 7673 7673
=======================================
Hits 7055 7055
Misses 618 618 🚀 New features to boost your workflow:
|
|
@melonora I summon you as a "Windows x Dask" expert. Do you have any insight on why this specific Windows job fails (the dask computational graph shows double the size): https://github.com/scverse/spatialdata/actions/runs/21940345294/job/63754609282?pr=1071. The test failing means that there may be some performance penalty in that environment. Anyway since the result is correct and it the test doesn't fail for other OS versions or more recent Dask, that will not block the merge. |
|
I will check when back at home, but yes I have my suspicion |
|
Thanks I will fix the docs meanwhile. |
|
Docs are green! |
|
Reporting: I think the failing test is overall faulty, depending on the actual purpose. We are actually testing more dask internals here instead of ensuring that we don't have more than expected entry points in our codebase to dask. This means that My suggestion would be to either ensure that there are no more expected calls from the spatialdata side, e.g. if you write there should be only one entry point or we test that the amount of times that chunks are accessed fall within a range of 2*chunks and if that test fails we report it upstream to dask. @LucaMarconato WDYT? |
|
Thanks for reporting!
sounds good to me! |
|
@flying-sheep Thanks! Just waiting for tests to pass and then will merge. Love your commit messages btw haha |
| uv pip install --prerelease allow pandas | ||
| else | ||
| uv sync --extra test | ||
| sed -i '' 's/requires-python.*//' pyproject.toml # otherwise uv complains that anndata requires python>=3.12 and we only do >=3.11 😱 |
There was a problem hiding this comment.
Changing the whole test setup to hatch would remove the need for this hack btw.
Not saying you should do it if the current setup works for you, only that having something manage multiple test conditions for you (locally the same way as in CI) is something I enjoy in developing my projects (even though learning hatch’s config semantics takes time)
There was a problem hiding this comment.
Could also use pixi no? E.g. would solve the same thing (bit biased here as I use pixi more haha))
tests: partial fix of tests failing due to anndata-git and pandas >=3
…ask 2025.2.0. fix tests test: adjust test to account for dask issues
fix docs attempt fix docs attempt 2 fix docs


Fixes #1039
I changed the test setup to use
uv add, which actually makes sense and results in a single solve per env, as I’ve been preaching since the dawn of time.Don’t use
[uv] pip installin CI people. Ever. Why does nobody trust me on that?