Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #22 +/- ##
==========================================
- Coverage 96.95% 96.86% -0.10%
==========================================
Files 11 12 +1
Lines 164 223 +59
==========================================
+ Hits 159 216 +57
- Misses 5 7 +2 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #22 will improve performances by ×3.6Comparing Summary
Benchmarks breakdown
|
ilan-gold
left a comment
There was a problem hiding this comment.
So the goal of this is to speed up imports? Looking at the code, I'm not sure it's worth this level of complexity TBH.
Things like:
@_sum.register("dask.array:Array")
make me cringe a bit. I would need to let this sit with me for a bit before I'd give it a sign-off. I'm very hesitant
|
The syntax is actually a Python standard used in entry points, e.g. |
|
I meant more creating a custom |
|
I think honestly that I don't see the tradeoff here worth it IMO. I think the complexity of this sort of thing can make our code unapproachable to people who might want to contribute. I understand if the complexity is really necessary here, but I don't personally feel it is needed here :/ |
On my systems, this speeds up import:
(in an environment with everything except Cupy installed)
TODO:
singledispatch