(feat): use numpy nan-able string type for anndata.experimental.MaskedArray#2011
(feat): use numpy nan-able string type for anndata.experimental.MaskedArray#2011
anndata.experimental.MaskedArray#2011Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2011 +/- ##
==========================================
- Coverage 87.47% 85.46% -2.02%
==========================================
Files 46 46
Lines 7056 7057 +1
==========================================
- Hits 6172 6031 -141
- Misses 884 1026 +142
|
|
Didn't we discuss this before? I must have suggested this when this came out. Do we have an issue? |
|
@flying-sheep I didn't even think to look. I wasn't aware of this until it came up in the linked PR. In any case I don't see anything. |
|
I mentioned numpy's string type here: #679 (comment) I think this needs more testing, e.g. what when someone sticks in a masked array based on a regular numpy array? |
Could you be a bit more specific? You're saying if some does something like |
|
OK, so is this only an implementation detail and the user-facing data type is always a pandas Series, or is there a way to see a numpy array with that dtype as a user? |
Right, this will be hidden behind |
anndata.experimental.MaskedArray
Using direct nan-able types is much better than object dtypes. In theory, this functionality should be usable independent of the new zarr dtype business and give us stronger typing going forward.