refactor(common): use strings.ToLower for LOG_DOCKER env variable check to improve code readability and maintainability#1035
Merged
0xmountaintop merged 2 commits intoscroll-tech:developfrom Dec 11, 2023
Conversation
…ck to improve code readability and maintainability
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1035 +/- ##
========================================
Coverage 48.04% 48.05%
========================================
Files 101 101
Lines 10695 10695
========================================
+ Hits 5138 5139 +1
+ Misses 5127 5126 -1
Partials 430 430
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
0xmountaintop
changed the title
strings.ToLower for LOG_DOCKER env variable check to improve code readability and maintainability
0xmountaintop
approved these changes
Dec 11, 2023
Contributor
|
rollup tests seem be broken by #1032 |
0xmountaintop
approved these changes
Dec 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.