Merged
Conversation
✅ Deploy Preview for scroll-documentation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
|
Personally,
I use dark mode religiously, and it is easier to read (IMHO).
…Sent from my iPhone
On Jul 17, 2024, at 7:17 PM, Daniel Helm ***@***.***> wrote:
I like the direction of this. I feel like the contrast now is too low, but if you're a regular dark mode user, I'll defer to your judgement here.
There are errors in rendering the Tabs component:
image.png (view on web)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
|
Member
Author
The tabs style has been fixed and the contrast has been adjusted. @dghelm |
dghelm
approved these changes
Jul 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Adjust Document Dark Mode Text Color
The current text color in dark mode has a high contrast that is uncomfortable for reading. Adjust the text color to reduce the contrast and enhance readability.