optimize extrapolation with zero field inverse during runtime#956
Merged
hero78119 merged 1 commit intoscroll-tech:masterfrom May 29, 2025
Merged
Conversation
hero78119
force-pushed
the
feat/opt_serial_sumcheck
branch
from
653bac9 to
7b075ec
Compare
hero78119
force-pushed
the
feat/opt_serial_sumcheck
branch
from
7b075ec to
80fc89f
Compare
hero78119
changed the title
hero78119
force-pushed
the
feat/opt_serial_sumcheck
branch
from
80fc89f to
6e1ab56
Compare
hero78119
force-pushed
the
feat/opt_serial_sumcheck
branch
from
6e1ab56 to
c0d01d3
Compare
spherel
reviewed
May 29, 2025
| ))] | ||
| pub struct IOPProof<E: ExtensionField> { | ||
| pub point: Vec<E>, | ||
| pub point: Point<E>, |
Member
There was a problem hiding this comment.
I just found Point<E> shouldn't be included in IOPProof<E>. What do you think about it?
Collaborator
Author
There was a problem hiding this comment.
yes I agree with you we should remove it and I will submit another PR to do that since in involved more change outside of this scope
github-merge-queue Bot
pushed a commit
that referenced
this pull request
May 29, 2025
build on top of #956 to address review comments clean up point from sumcheck proof, as verifier should derived itself
hero78119
added a commit
to hero78119/ceno
that referenced
this pull request
May 30, 2025
…-tech#956) Extracted from scroll-tech#952. Observe a bottleneck on previous interpolation which contribute to most of time due to `vector.extend` operation and bunch of allocations. This PR rewrite univariate extrapolation 1. as the point to be interpolate are fixed set, we can pre-compute all stuff require field inverse 2. in-place change to avoid allocation In Ceno opcode main sumcheck part we batch different degree > 1 into one batch so this function will be used. It shows a slightly improvement (~3%) on Fibonacci 2^24 e2e | Benchmark | Median Time (s) | Median Change (%) | |----------------------------------|------------------|--------------------| | fibonacci_max_steps_1048576 | 2.3978 | +0.9805% (No significant change ) | | fibonacci_max_steps_2097152 | 4.2579 | +1.7587% (Change within noise) | | fibonacci_max_steps_4194304 | 7.7561 | -3.5338% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #952.
Observe a bottleneck on previous interpolation which contribute to most of time due to
vector.extendoperation and bunch of allocations.This PR rewrite univariate extrapolation
benchmark
In Ceno opcode main sumcheck part we batch different degree > 1 into one batch so this function will be used.
It shows a slightly improvement (~3%) on Fibonacci 2^24 e2e