Suggestions for 'Frontend and backend for building circuits'#801
Merged
dreamATD merged 4 commits intotianyi/refactor-proverfrom Jan 6, 2025
Merged
Suggestions for 'Frontend and backend for building circuits'#801dreamATD merged 4 commits intotianyi/refactor-proverfrom
dreamATD merged 4 commits intotianyi/refactor-proverfrom
Conversation
matthiasgoergens
changed the base branch from
master
to
tianyi/refactor-prover
dreamATD
approved these changes
Jan 6, 2025
Collaborator
dreamATD
left a comment
dreamATD
left a comment
There was a problem hiding this comment.
Thanks, it makes it more dry!
dreamATD
added a commit
that referenced
this pull request
Jan 15, 2025
Suggestions for #799 Feel free to pick and choose from the suggestions. I talk about most of them on your PR. --------- Co-authored-by: dreamATD <tianyi.liu.08@gmail.com>
dreamATD
added a commit
that referenced
this pull request
Feb 19, 2025
Suggestions for #799 Feel free to pick and choose from the suggestions. I talk about most of them on your PR. --------- Co-authored-by: dreamATD <tianyi.liu.08@gmail.com>
dreamATD
added a commit
that referenced
this pull request
Mar 22, 2025
Suggestions for #799 Feel free to pick and choose from the suggestions. I talk about most of them on your PR. --------- Co-authored-by: dreamATD <tianyi.liu.08@gmail.com>
dreamATD
added a commit
that referenced
this pull request
Mar 22, 2025
Remove buffers and replace the underlying util functions. Add comments and fix some tiny bugs Suggestions for 'Frontend and backend for building circuits' (#801) Suggestions for #799 Feel free to pick and choose from the suggestions. I talk about most of them on your PR. --------- Co-authored-by: dreamATD <tianyi.liu.08@gmail.com> Refine according to comments refine the protocol prover and verifier structs Add more comments Tiny fix according to the latest comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggestions for #799
Feel free to pick and choose from the suggestions. I talk about most of them on your PR.