Conversation
SimonHeybrock
approved these changes
Apr 30, 2026
MridulS
approved these changes
Apr 30, 2026
Member
MridulS
left a comment
There was a problem hiding this comment.
I'm okay with this too, we just need to be consistent :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #560 for context and discussion.
Plopp uses Scipp everywhere internally. It makes sense that it should be a hard requirement.
Until now, we had it as a soft dependency because of fears of ending up in a circular dependency issue where plopp needs scipp but scipp needs plopp (because it imports it and adds the
.plot()methods to DataArray).But as long as Plopp just remains a soft dependency of Scipp, solving environments should be fine.
pip install plopp, you would get plopp and scipp (and skip scipp if it is already installed)pip install scipp, you get only scipppip install scipp ploppyou get both at once, as expected.This will also make it easier to keep our conda recipe healthy and in-sync with the pyproject.toml here.