Skip to content

Make Scipp a hard dependency of Plopp#561

Merged
nvaytet merged 3 commits intomainfrom
hard-scipp-dep
Apr 30, 2026
Merged

Make Scipp a hard dependency of Plopp#561
nvaytet merged 3 commits intomainfrom
hard-scipp-dep

Conversation

@nvaytet
Copy link
Copy Markdown
Member

@nvaytet nvaytet commented Apr 30, 2026

See #560 for context and discussion.

Plopp uses Scipp everywhere internally. It makes sense that it should be a hard requirement.
Until now, we had it as a soft dependency because of fears of ending up in a circular dependency issue where plopp needs scipp but scipp needs plopp (because it imports it and adds the .plot() methods to DataArray).

But as long as Plopp just remains a soft dependency of Scipp, solving environments should be fine.

  • if you pip install plopp, you would get plopp and scipp (and skip scipp if it is already installed)
  • if you pip install scipp, you get only scipp
  • if you pip install scipp plopp you get both at once, as expected.

This will also make it easier to keep our conda recipe healthy and in-sync with the pyproject.toml here.

Copy link
Copy Markdown
Member

@MridulS MridulS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with this too, we just need to be consistent :)

@nvaytet nvaytet merged commit 04ddd63 into main Apr 30, 2026
6 checks passed
@nvaytet nvaytet deleted the hard-scipp-dep branch April 30, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants