Skip to content

feat: Add 'name-tests-test' to pre-commit hooks#86

Merged
henryiii merged 2 commits intomainfrom
feat/add-name-tests-test
Jun 23, 2022
Merged

feat: Add 'name-tests-test' to pre-commit hooks#86
henryiii merged 2 commits intomainfrom
feat/add-name-tests-test

Conversation

@matthewfeickert
Copy link
Copy Markdown
Member

@matthewfeickert matthewfeickert commented Jun 16, 2022

Motivated by scikit-hep/scikit-hep.github.io#227 and complimentary to PR scikit-hep/scikit-hep.github.io#231.

  • Update pre-commit/pre-commit-hooks to v4.3.0
  • Add the 'name-tests-test' pre-commit hooks which verifies that test files under tests/ conform to pytest naming conventions.
    • Use the --pytest-test-first option to match the test_.*\.py naming convention.

@matthewfeickert matthewfeickert added the enhancement New feature or request label Jun 16, 2022
@matthewfeickert matthewfeickert requested a review from henryiii June 16, 2022 02:16
@matthewfeickert matthewfeickert self-assigned this Jun 16, 2022
* Add the 'name-tests-test' pre-commit hooks which verifies that test files
under tests/ conform to pytest naming conventions.
   - Use the '--pytest-test-first' option to match the 'test_.*\.py' naming convention.
@matthewfeickert matthewfeickert force-pushed the feat/add-name-tests-test branch from 6484b02 to 1c1d3d7 Compare June 22, 2022 15:44
@henryiii henryiii merged commit b43e5dd into main Jun 23, 2022
@henryiii henryiii deleted the feat/add-name-tests-test branch June 23, 2022 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants