Port agent PR review workflow to XGrowthDashboard (#x-growth-dashboard)#12
Port agent PR review workflow to XGrowthDashboard (#x-growth-dashboard)#12scalinity wants to merge 1 commit into
Conversation
Add XGrowthDashboard-tailored workflow, PR template, and AGENTS/README sections under porting/. Expand everybot README with retroactive kickoff notes. Co-authored-by: Daniel Escalante <scalinity@users.noreply.github.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Agent review debateThis pull request was opened by an automated agent (Cursor Cloud Agent). Starting the cross-agent review thread so we capture findings before merge.
@codex review @claude Please review this PR and engage with Codex's findings — agree or disagree on each P0/P1, note missing risks, and keep the debate in this thread before merge. Review focus (everybot)
Repo guidance: see Automated by agent-pr-review-kickoff.yml · PR: #12 |
|
To use Codex here, create a Codex account and connect to github. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ce4ff231f5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| The point of the per-sub-task push is the same point Linear would serve: an external observer can audit which finding produced which commit without trawling for `[PRE-EXISTING]` prefixes or commit-body footnotes. | ||
|
|
||
| --- |
There was a problem hiding this comment.
Remove copied context from AGENTS snippet
When someone follows the documented manual path and appends AGENTS-review-section.md before the existing ## What this file is not, this snippet also inserts the pre-existing paragraph/separator and another ## What this file is not section, duplicating target-repo content instead of adding only the review guidelines. Trimming this file to just the new ## Agent PR review guidelines and ## Cross-agent debate block would make the manual copy route match the patch.
Useful? React with 👍 / 👎.
| # X Growth Dashboard | ||
|
|
||
| Local-first "weight-loss dashboard for X growth." Single-user personal tool. Not distributed. | ||
|
|
||
| See `spec.md` for the full product spec and `docs/IMPLEMENTATION_STATUS.md` for current phase. |
There was a problem hiding this comment.
Remove README header from inserted snippet
The porting README says to insert README-agent-review-section.md after the existing intro paragraph, but this file starts with the target README's title and intro again. Following the manual instructions would duplicate the top of README.md; this snippet should contain only the new ## Agent PR reviews section if it is meant to be inserted.
Useful? React with 👍 / 👎.
| name: Agent review kickoff | ||
|
|
||
| on: | ||
| pull_request: |
There was a problem hiding this comment.
Use a trigger that can comment on fork PRs
For cursor/* PRs opened from forks, pull_request runs with a read-only GITHUB_TOKEN, so the later issues.createComment call will 403 despite the requested issues: write permission and the kickoff comment never appears. Because this workflow only reads PR metadata and posts a comment, switch this commenting job to pull_request_target without checking out head code, or explicitly restrict/document the automation as same-repository branches only.
Useful? React with 👍 / 👎.
| const { data: comments } = await github.rest.issues.listComments({ | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| issue_number: prNumber, | ||
| per_page: 100, |
There was a problem hiding this comment.
Paginate before deciding the kickoff already ran
On a retroactive workflow_dispatch for a PR that already had more than 100 comments before the first kickoff was posted, this call only checks the first page of comments, so later reruns will not see the marker and will post duplicate agent-review comments. Use pagination (for example github.paginate) when searching for the marker.
Useful? React with 👍 / 👎.
| Or apply the included patch from repo root: | ||
|
|
||
| ```bash | ||
| git am porting/XGrowthDashboard/0001-feat-ci-add-agent-PR-review-kickoff-workflow-for-cur.patch |
There was a problem hiding this comment.
Point git-am at the exported patch
When these instructions are followed from a fresh XGrowthDashboard checkout, porting/XGrowthDashboard/... does not exist there, so the advertised patch-apply path fails before git am can run. Use the absolute/relative path to the everybot checkout's exported patch here, matching the PR body, or tell the user to copy the patch into the target repo first.
Useful? React with 👍 / 👎.
|
Closed via Close open pull requests workflow (team cleanup). |
Summary
Implements the Codex ↔ Claude agent PR review kickoff pattern from scalinity/everybot for scalinity/XGrowthDashboard (#x-growth-dashboard).
The Cloud Agent token can push to
everybotbut not toXGrowthDashboard, so this PR lands the XGrowth-tailored files underporting/XGrowthDashboard/for a one-step apply to the dashboard repo.Apply to XGrowthDashboard
From a fresh
maincheckout of scalinity/XGrowthDashboard:Or follow porting/XGrowthDashboard/README.md to copy files manually.
What gets added (at XGrowth repo root)
AGENTS.md.github/workflows/agent-pr-review-kickoff.ymlcursor/*PRs;workflow_dispatch+pr_numberfor retroactive runs.github/pull_request_template.mdREADME.mdeverybot change
README.md— retroactive kickoff instructions (@codex reviewmust be in a comment, not only the PR body)Validation
actionlintpasses onporting/XGrowthDashboard/.github/workflows/agent-pr-review-kickoff.ymlcursor/*→github-actions[bot]posts one kickoff comment (marker<!-- agent-review-kickoff -->)Agent review
@codex @claude — review this port PR; once applied on XGrowthDashboard, re-run the debate on that repo's
cursor/*PR.Slack Thread