Change model failures to slightly more likely mistake.#373
Merged
fbergmann merged 1 commit intodevelopmentfrom Aug 5, 2024
Merged
Change model failures to slightly more likely mistake.#373fbergmann merged 1 commit intodevelopmentfrom
fbergmann merged 1 commit intodevelopmentfrom
Conversation
The original version of these files was indeed wrong as per the failure they are supposed to test, but it's slightly more likely that someone might make a mistake putting in a correctly-spelled-but-incorrectly-placed 'modifierSpeciesReference' than they are to put in an incorrectly-spelled-and-also-incorrectly-placed 'modiferSpeciesReference'.
fbergmann
approved these changes
Aug 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original version of these files was indeed wrong as per the failure they are supposed to test, but it's slightly more likely that someone might make a mistake putting in a correctly-spelled-but-incorrectly-placed 'modifierSpeciesReference' than they are to put in an incorrectly-spelled-and-also-incorrectly-placed 'modiferSpeciesReference'.
See #372.