chore: add OSS community files and CI#45
Merged
Merged
Conversation
Annotate the RUN_* result-interface assignments (SC2034) and extend the test suite's disable list (SC2034/SC2329) so shellcheck passes at full strictness, matching the documented dev gate.
Run bash syntax check, the shell test suite, version/help, and a release dry-run on ubuntu and macOS, plus shellcheck lint.
Add CONTRIBUTING, CODE_OF_CONDUCT (Contributor Covenant 2.1), SECURITY, a PR template, and bug/feature issue forms.
Generate CHANGELOG.md with git-cliff so the changelog is populated ahead of the next release regeneration.
The placeholder-skip rule used \< \> which GNU awk treats as word boundaries, so quoted frontmatter values like "Chat Retry" were dropped to empty on gawk/mawk runners. Use literal angle brackets so the rule skips only <placeholder> lines on BSD awk, gawk, and mawk alike.
Older shellcheck versions on CI report unreachable-command (SC2317) for indirectly-invoked test stubs where newer versions report SC2329. Disable both so lint passes regardless of shellcheck version.
The gh-missing assertions appended raw /usr/bin:/bin to PATH, so on CI runners that ship gh in /usr/bin the tests saw gh present and failed. Mirror the system bin dirs into a sanitized dir that excludes gh, so command -v gh fails regardless of host gh location.
The direct devloop_doctor test relied on the ambient PATH supplying devloop, gum, and fzf, which only happens on a provisioned dev machine. On CI those are absent, so doctor reported not-ready. Supply all required deps via the controlled stub dirs (bin_dir, tool_bin) and sanitized system bin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The repo is missing the standard scaffolding GitHub flags under Community Standards, and there's no CI enforcing the documented dev gates on PRs.
Approach
Add the missing pieces (release tooling and
cliff.tomlwere already in place):.github/workflows/ci.yml): bash syntax check,scripts/devloop_test.sh, version/help, and a release dry-run on ubuntu + macOS, plus shellcheck lint.CONTRIBUTING.md,CODE_OF_CONDUCT.md(Contributor Covenant 2.1),SECURITY.md, PR template, and bug/feature issue forms.CHANGELOG.mdfrom history (was empty).scripts/release.sh --publishcontinues to regenerate it via git-cliff on each release.shellcheckpasses at full strictness, matching the README gate.Commits are split one-logical-change each.
Test evidence
CI runs the same gates on this PR.