Skip to content
This repository was archived by the owner on Oct 24, 2025. It is now read-only.

Exposed percision settings#19

Merged
bolandrm merged 1 commit intosass:masterfrom
huangyq23:precision_settings
Sep 30, 2015
Merged

Exposed percision settings#19
bolandrm merged 1 commit intosass:masterfrom
huangyq23:precision_settings

Conversation

@huangyq23
Copy link
Copy Markdown

We are moving from the sass gem to sassc-ruby gem and found precision setting was missing from the API binding.

Our use case needs this to keep the output consistent.

@bolandrm
Copy link
Copy Markdown
Member

Hello!

can you please add a test demonstrating what happens if precision is not set?

i.e.

def test_precision_not_specified
  template = <<-SCSS
$var: 1;
.foo {
  baz: $var / 3; }
SCSS

  expected_output = <<-CSS
.foo {
  baz: ?????? ; } 
CSS

  output = Engine.new(template).render
  assert_equal expected_output, output
end

then i'll merge

@huangyq23
Copy link
Copy Markdown
Author

@bolandrm added.

@bolandrm
Copy link
Copy Markdown
Member

perfect. thanks!

bolandrm added a commit that referenced this pull request Sep 30, 2015
@bolandrm bolandrm merged commit fdd9eb8 into sass:master Sep 30, 2015
@huangyq23
Copy link
Copy Markdown
Author

@bolandrm what does the release process work for this gem? I am fine with locking it down to a git commit, but it would be nice if we get a actual version to reference in Gemfile.

@bolandrm
Copy link
Copy Markdown
Member

@huangyq23 I released 1.7.0 for you.

@huangyq23
Copy link
Copy Markdown
Author

Nice, thanks!

@printercu
Copy link
Copy Markdown

Can this one be used with sassc-rails? Maybe something like SassC::Engine.precision = 8?

michael-gillett pushed a commit to michael-gillett/sassc-ruby that referenced this pull request Apr 25, 2019
use ddog if production for error notification
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants