functions: Fixing a logical mistake#145
Closed
thopiekar wants to merge 1 commit intosameersbn:masterfrom
thopiekar:patch-1
Closed
functions: Fixing a logical mistake#145thopiekar wants to merge 1 commit intosameersbn:masterfrom thopiekar:patch-1
thopiekar wants to merge 1 commit intosameersbn:masterfrom
thopiekar:patch-1
Conversation
I'm not getting how this section of code could ever be made. 1. Why do we search for a file or directory, when we have an if-clause on top, which already checks for it? Searching for something that has already been found is pointless. 2. Why is there a search for a file (that is the bug I'm actually running into here), if we already know the path is a file type of data? It's like checking for something and knowing already it will fail. When thinking of the name of the environment variable, I think only the directory check is necessary, but someone added the "-f" check. Maybe to test for symlinks? (It would be normally done via "-L" if I'm not wrong, but "-f" catches them, too.) For the reason of knowing to less of the history of this section, I'm keeping as much logic as possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not getting how this section of code could ever be made.
When thinking of the name of the environment variable, I think only the directory check is necessary, but someone added the "-f" check. Maybe to test for symlinks? (It would be normally done via "-L" if I'm not wrong, but "-f" catches them, too.) For the reason of knowing to less of the history of this section, I'm keeping as much logic as possible.