Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Merge this one first and then the Cache plugin
Sister PR: saloonphp/cache-plugin#18
Fixes: #547
When the response cache plugin runs, it can read and write cached payloads before mocked responses are resolved again. That makes fixture-based mocks appear stuck after the first request.
This PR adds an explicit opt-out on MockClient:
withoutCache(): mark this mock client so downstream code can skip response cachingshouldBypassResponseCache(): query that flag (used by the cache plugin)Saloon::fake([...])->withoutCache()continues to work because the Laravel helper returns the global MockClient.This PR also Includes a unit test covering the addition.