fix for larger matrices - #17
Closed
bluppfisk wants to merge 2 commits into
Closed
Conversation
will now correctly handle setPattern() with delimiters. Lack of delimiters on matrices with > 9 dots means that dot '10' will be interpreted as two dots: '1' and '0'. This fixes that. Mind that you need to set the correct delimiter in the lock that gets setPattern().
Owner
|
Can't merge as its showing all the lines are committed. Will be hard to track later. I will fix the issue as a separate commit. |
Owner
|
Also we should support both array and string for the pattern passed . Will add that check too. |
s-yadav
added a commit
that referenced
this pull request
Jul 17, 2016
Author
|
Good points. Yes I think using Git's Windows program messed up the line |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
will now correctly handle setPattern() with delimiters. Lack of
delimiters on matrices with > 9 dots means that dot '10' will be
interpreted as two dots: '1' and '0'. This fixes that.
Mind that you need to set the correct delimiter in the lock that gets
setPattern().