Move method context to do_execute_method#296
Open
martin-hughes wants to merge 1 commit intorust-osdev:mainfrom
Open
Move method context to do_execute_method#296martin-hughes wants to merge 1 commit intorust-osdev:mainfrom
do_execute_method#296martin-hughes wants to merge 1 commit intorust-osdev:mainfrom
Conversation
Then there's no way for re-entrancy to corrupt the stack. Fixes rust-osdev#292.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A potential fix for #292.
As discussed in the issue, I've moved the method context into
do_execute_method. It's a pretty straightforward change.I can't see any particular downside so I've opened this PR - hopefully @IsaacWoods you won't remember a key reason why this is bad 😆