Get referenced-package size - unwrap reference in do_size_of#288
Open
martin-hughes wants to merge 1 commit intorust-osdev:mainfrom
Open
Get referenced-package size - unwrap reference in do_size_of#288martin-hughes wants to merge 1 commit intorust-osdev:mainfrom
do_size_of#288martin-hughes wants to merge 1 commit intorust-osdev:mainfrom
Conversation
IsaacWoods
reviewed
Apr 29, 2026
| Method (MAIN, 0, NotSerialized) { | ||
| Local0 = Sizeof (FOO) // Should be 3 | ||
| Local1 = Sizeof (FOO[0]) // Should be 1. This was the failing line. | ||
| Return ((Local0 + Local1) - 4) |
Member
There was a problem hiding this comment.
As booleans are just integers in AML, does something like Return (!((Local0 != 3) || (Local1 != 1))) work?
Contributor
Author
There was a problem hiding this comment.
Great plan that I should have thought of! I tried it and generated #294 instead 😆
Actually I think the leading not is not needed. So I've pushed a slightly different version.
martin-hughes
force-pushed
the
issue-282-unwrap-refs
branch
from
74b37ed to
41c190c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pretty much what it says in the title. Closes #282
I didn't do anything fancy like I thought I might do, just a simple fix here.