Conversation
bluss
left a comment
bluss
left a comment
There was a problem hiding this comment.
Nice work. Since this is a breaking change we need to resolve any 0.15.x changes before merging this.
|
Thanks, looks good. |
|
This is good and just waiting to be able to be integrated. After 0.15.x changes are resolved. No schedule, but it's more than a month until then. |
|
Just to note, that it's finally time to accept breaking changes 🙂 |
Add From impl to convert from 2D slices to 2D views Move NdIndex<IxDyn> implementations for arrays out of macros Remove FixedInitializer trait Make bounds checks in aview2 and aview_mut2 conditional on slices of ZSTs Refactor aview2 and aview_mut2 implementations into From
YuhanLiin
force-pushed
the
const-generics
branch
from
999ec8c to
ad66360
Compare
src/arraytraits.rs
Outdated
| use crate::imp_prelude::*; | ||
| use crate::iter::{Iter, IterMut}; | ||
| use crate::NdIndex; | ||
| use crate::{dimension, imp_prelude::*}; |
There was a problem hiding this comment.
I don't know what tool put this use here, but prelude-like imports should be on their own line, with a newline separating from the others.
| a.remove_index(Axis(1), 2); | ||
| assert_eq!(a.shape(), &[3, 2]); | ||
| assert_eq!(a, | ||
| array![[1, 2], |
There was a problem hiding this comment.
Sorry to nitpick, but when the code is arranged to be easy to read (multiline array), it should not be reformatted.
There was a problem hiding this comment.
I have my editor set to automatically run rustfmt. I'll revert the format changes to this file.
|
Why are there CI Clippy errors in code I didn't change? |
|
clippy is using the beta branch, so it gets updates and sometimes finds new lints. Dont' bother with irrelevant clippy warnings |
|
CI passes for all steps except for Clippy. |
|
Thanks |
3 participants
Adds the easy const generics improvements mentioned in #961. This includes implementation of
IntoNdProducer,FixedInitializer, andNdIndex<IxDyn>for arrays as well asFromimplementations for 2D slices (slices of higher dimensions is also possible).