Travis runs on all branches#645
Conversation
|
Gentle reminder on this, lmk any feedback, thanks |
|
You can better add |
|
@burrbull What advantage does that have over the proposed changes? |
|
This repo has 15 branches and a lot of forks. You want to make travis to build after any change in any branch. It's bad way. |
|
TBC, this repo's Travis only runs on a change in a fork if that fork has a open PR - it's the other fork's travis that would run on a change. I maintain https://github.com/pydata/xarray, which has 408 forks, and the proposed model works great. I've never seen the existing model before - is it prevalent? |
|
My understanding is in line with @max-sixty - it will only run on Unless there is something I am missing, I would go ahead and merge the change after #628 is finalized. |
|
No need to wait in the end, the conflict would be extremely minor. |
|
Cheers @LukeMathWalker ! |
Was there a reason to have this filter?
The existing code wouldn't kick off travis runs on my fork's travis (i.e. https://travis-ci.org/max-sixty/ndarray/branches), which I think means I need to create a PR to see a travis run.
The proposed code will kick off a travis run on any branch (on forks which have travis enabled)
But if this was deliberate for some reason then feel free to close