Fix trait bound on arr1 (op) &arr2#380
Merged
bluss merged 1 commit intorust-ndarray:masterfrom Nov 20, 2017
Merged
Conversation
The implementation of `arr1 (op) &arr2` mutates `arr1` for efficiency,
but this caused surprising behavior if `arr1` was `ArrayViewMut`. This
commit requires that `arr` own its data to avoid surprising side
effects.
This is an example of the old behavior that was surprising:
```rust
extern crate ndarray;
fn main() {
let mut a = array![1., 2.];
let b = array![3., 4.];
// Prints a = [1, 2].
println!("a = {}", a);
{
let a_view_mut = a.view_mut();
// Prints a + b = [4, 6].
println!("a + b = {}", a_view_mut + &b);
}
// Prints a = [4, 6]; would expect a = [1, 2].
println!("a = {}", a);
}
```
Note that while this is a breaking change, the stricter trait bound is
actually the correct bound according to the documentation.
Member
|
Right, we have probably fixed this already for the other ops. |
Member
|
Thanks |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementation of
arr1 (op) &arr2mutatesarr1for efficiency, but this caused surprising behavior ifarr1wasArrayViewMut. This commit requires thatarrown its data to avoid surprising side effects.This is an example of the old behavior that was surprising:
Note that while this is a breaking change, the stricter trait bound is actually the correct bound according to the documentation.