Skip to content

Add ADX-related intrinsics#631

Merged
alexcrichton merged 1 commit intorust-lang:masterfrom
alexcrichton:adx
Jan 7, 2019
Merged

Add ADX-related intrinsics#631
alexcrichton merged 1 commit intorust-lang:masterfrom
alexcrichton:adx

Conversation

@alexcrichton
Copy link
Copy Markdown
Member

Closes #322

Comment thread coresimd/x86/adx.rs Outdated
Comment thread crates/stdsimd-verify/tests/x86-intel.rs Outdated
@alexcrichton alexcrichton force-pushed the adx branch 2 times, most recently from aa0b548 to d865c17 Compare January 7, 2019 16:03
@alexcrichton alexcrichton merged commit d464018 into rust-lang:master Jan 7, 2019
@alexcrichton alexcrichton deleted the adx branch January 7, 2019 16:04
Comment thread coresimd/x86/adx.rs
/// the carry-out is returned (carry or overflow flag).
#[inline]
#[target_feature(enable = "adx")]
#[cfg_attr(test, assert_instr(adc))]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is correct, it should say adcx

Copy link
Copy Markdown
Contributor

@gnzlbg gnzlbg Jan 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jethrogb Could you submit a PR with that fix?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some work is involved in actually making it work that way, see #663

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've opened an issue so that we don't forget about this #666

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants