rustup_mode.rs: Break up CLI generation to let rustfmt work#2097
Merged
kinnison merged 1 commit intorust-lang:masterfrom Oct 29, 2019
Merged
rustup_mode.rs: Break up CLI generation to let rustfmt work#2097kinnison merged 1 commit intorust-lang:masterfrom
kinnison merged 1 commit intorust-lang:masterfrom
Conversation
Signed-off-by: Daniel Silverstone <dsilvers@digital-scurf.org>
Contributor
|
It's best to create a minimal example and report the problem in rustfmt issue. |
Contributor
Author
|
@lzutao There already is a rustfmt issue which I'm subscribed to; but the fix isn't slated until rustfmt 2.0 so for now we need the change in rustup :D |
payload
reviewed
Dec 6, 2019
| ); | ||
|
|
||
| // We break the app creation here so that rustfmt can cope | ||
| // If rustfmt ceases to format this block, break it up further |
Contributor
There was a problem hiding this comment.
Is there an issue about that in rustfmt?
Contributor
Author
There was a problem hiding this comment.
This is indeed a known issue in rustfmt though I was told it's unlikely to be resolved before 2.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason
rustfmtwas hitting a brick wall when formatting the expression which was the majority ofrustup_mode.rs's CLI. This PR breaks that up so that formatting works again.