Skip to content

feature: added exercise to "traits" chapter#1472

Closed
abhi3700 wants to merge 3 commits into
rust-lang:mainfrom
abhi3700:main
Closed

feature: added exercise to "traits" chapter#1472
abhi3700 wants to merge 3 commits into
rust-lang:mainfrom
abhi3700:main

Conversation

@abhi3700

@abhi3700 abhi3700 commented Apr 7, 2023

Copy link
Copy Markdown

This is an attempt to add 1 exercise in "traits" chapter.

The objective is to let the developer learn these:

  • "How to implement at function that can return incompatible types?"
  • "How to make the same function printable on console?"

Looking forward to getting feedback on this.

@poneciak57

Copy link
Copy Markdown
Contributor

Exercise traits6 is unnecessarily large, tests seems redundant here.

@abhi3700

abhi3700 commented Apr 7, 2023

Copy link
Copy Markdown
Author

Exercise traits6 is unnecessarily large, tests seems redundant here.

I can add ?? in tests.

Or I just have only ‘traits7.rs’

@poneciak57

Copy link
Copy Markdown
Contributor

I think u can just delete tests and add main function with simple showcase.

@abhi3700

abhi3700 commented Apr 8, 2023

Copy link
Copy Markdown
Author

I think u can just delete tests and add main function with simple showcase.

ok followed

@abhi3700 abhi3700 changed the title feature: added exercises to "traits" chapter feature: added exercise to "traits" chapter Apr 8, 2023
@abhi3700

abhi3700 commented Jun 6, 2023

Copy link
Copy Markdown
Author

Can this be merged?

@manyinsects

Copy link
Copy Markdown
Member

This seems to me like too much of a jump between complexity in exercises (e.g. I don't think we should be touching dyn at this point, or Box before the exercise in which it's introduced).

@manyinsects manyinsects closed this Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants