This repository was archived by the owner on Nov 24, 2023. It is now read-only.
Bolster help and add Cargo flags #128
Closed
alexcrichton wants to merge 2 commits intorust-lang:masterfrom
Closed
Conversation
Previously it would block forever, now it should exit cleanly!
This commit explicitly takes many flags that Cargo takes to filter the package selection and otherwise configure what packages are being built or what targets are being built. The intention here is to take arguments but forward them all to the underlying `cargo check`, but doing so in a first-class fashion to avoid `--` if possible.
Contributor
|
Oh, sorry for not commenting here earlier. Do you still want to merge this here or is this already all part of rust-lang/cargo#5723? |
Member
Author
|
No worries! I think at this point I'll close in favor of the Cargo PR as this is included there as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit explicitly takes many flags that Cargo takes to filter the package
selection and otherwise configure what packages are being built or what targets
are being built. The intention here is to take arguments but forward them all to
the underlying
cargo check, but doing so in a first-class fashion to avoid--if possible.