create guide to ICE-breaker groups and specifically advice for LLVM#452
Merged
nikomatsakis merged 1 commit intorust-lang:masterfrom Oct 2, 2019
Merged
create guide to ICE-breaker groups and specifically advice for LLVM#452nikomatsakis merged 1 commit intorust-lang:masterfrom
nikomatsakis merged 1 commit intorust-lang:masterfrom
Conversation
10 tasks
spastorino
reviewed
Sep 21, 2019
Member
spastorino
left a comment
spastorino
left a comment
There was a problem hiding this comment.
Looks great, just left a couple of minor comments.
Seems good to merge for now because it clearly explains that there are things that we are currently figuring out.
nikomatsakis
force-pushed
the
icebreaker
branch
from
e61476b to
6675bfd
Compare
mark-i-m
pushed a commit
to spastorino/rustc-dev-guide
that referenced
this pull request
Jan 2, 2020
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @spastorino