[beta] backport EOVERFLOW handling from copy specialization PR#79028
Closed
the8472 wants to merge 1 commit intorust-lang:betafrom
Closed
[beta] backport EOVERFLOW handling from copy specialization PR#79028the8472 wants to merge 1 commit intorust-lang:betafrom
the8472 wants to merge 1 commit intorust-lang:betafrom
Conversation
Contributor
|
rust-highfive
added
the
S-waiting-on-review
Member
|
Going to close in favor of #79008, which I have now r+'d. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I apologize for the curse of choice. Here's the 3rd option to fix #78979
The alternatives are #79007 and #79008
Pros: this should directly address the reported error
Cons: this code has not been through enough testing since the PR from which it is extracted hasn't even landed yet.
CC @pietroalbini
r? @Mark-Simulacrum