polymorphize: if any param in a predicate is used, then all are used#75595
Merged
bors merged 1 commit intorust-lang:masterfrom Aug 20, 2020
Merged
Conversation
rust-highfive
added
the
S-waiting-on-review
eddyb
reviewed
Aug 16, 2020
eddyb
reviewed
Aug 16, 2020
eddyb
approved these changes
Aug 16, 2020
Member
eddyb
left a comment
eddyb
left a comment
There was a problem hiding this comment.
r=me with or without removing the predicate kind filtering
eddyb
added
S-waiting-on-author
This commit modifies polymorphization's handling of predicates so that if any generic parameter is used in a predicate then all parameters in that predicate are used. Signed-off-by: David Wood <david@davidtw.co>
davidtwco
force-pushed
the
polymorphization-predicate-simplification-correction
branch
from
71d4741 to
5703b28
Compare
davidtwco
added
S-waiting-on-review
eddyb
approved these changes
Aug 18, 2020
Member
|
@bors r+ |
Collaborator
|
📌 Commit 5703b28 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions, checks-azure |
davidtwco
deleted the
polymorphization-predicate-simplification-correction
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review comments from @eddyb in #75518 that I didn't get to resolve before bors merged.
This PR modifies polymorphization's handling of predicates so that if any generic parameter is used in a predicate then all parameters in that predicate are used.
r? @eddyb