Skip to content

Remove some uses of mem::uninitialized#62422

Merged
bors merged 3 commits intorust-lang:masterfrom
tesuji:remove-some-mem-uinit
Jul 7, 2019
Merged

Remove some uses of mem::uninitialized#62422
bors merged 3 commits intorust-lang:masterfrom
tesuji:remove-some-mem-uinit

Conversation

@tesuji
Copy link
Copy Markdown
Contributor

@tesuji tesuji commented Jul 5, 2019

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 5, 2019
@tesuji tesuji changed the title Remove use of mem::uninitialized Remove some uses of mem::uninitialized Jul 5, 2019
Comment thread src/libterm/win.rs Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is all of this diff about?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make CONSOLE_SCREEN_BUFFER_INFO definition like the one in winapi.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I can review Windows FFI code I am afraid. I can't even remember how big a DWORD is.

@RalfJung
Copy link
Copy Markdown
Member

RalfJung commented Jul 5, 2019

r? @alexcrichton
The MaybeUninit parts look good to me, but there's also some Windows FFI changes.

@alexcrichton
Copy link
Copy Markdown
Member

@bors: r+

@bors
Copy link
Copy Markdown
Collaborator

bors commented Jul 6, 2019

📌 Commit 6ca83c6d793e3336ae99087242c84153069c37e6 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 6, 2019
@tesuji tesuji force-pushed the remove-some-mem-uinit branch from 6ca83c6 to 7646d49 Compare July 6, 2019 03:27
@tesuji
Copy link
Copy Markdown
Contributor Author

tesuji commented Jul 6, 2019

Rebased to tidy history.

@RalfJung
Copy link
Copy Markdown
Member

RalfJung commented Jul 6, 2019

@bors r=alexcrichton

@bors
Copy link
Copy Markdown
Collaborator

bors commented Jul 6, 2019

📌 Commit 7646d49 has been approved by alexcrichton

Centril added a commit to Centril/rust that referenced this pull request Jul 6, 2019
…xcrichton

Remove some uses of mem::uninitialized

cc rust-lang#62397
r? @RalfJung
Centril added a commit to Centril/rust that referenced this pull request Jul 6, 2019
Rollup of 4 pull requests [1]

Successful merges:

 - rust-lang#62243 (Improve documentation for built-in macros)
 - rust-lang#62422 (Remove some uses of mem::uninitialized)
 - rust-lang#62432 (Update rustfmt to 1.3.2)
 - rust-lang#62436 (normalize use of backticks/lowercase in compiler messages for librustc_mir)

Failed merges:

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Jul 6, 2019
…xcrichton

Remove some uses of mem::uninitialized

cc rust-lang#62397
r? @RalfJung
Centril added a commit to Centril/rust that referenced this pull request Jul 6, 2019
…xcrichton

Remove some uses of mem::uninitialized

cc rust-lang#62397
r? @RalfJung
bors added a commit that referenced this pull request Jul 6, 2019
Rollup of 6 pull requests

Successful merges:

 - #60081 (Refactor unicode.py script)
 - #61862 (Make the Weak::{into,as}_raw methods)
 - #62243 (Improve documentation for built-in macros)
 - #62422 (Remove some uses of mem::uninitialized)
 - #62432 (Update rustfmt to 1.3.2)
 - #62436 (normalize use of backticks/lowercase in compiler messages for librustc_mir)

Failed merges:

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Jul 6, 2019
…xcrichton

Remove some uses of mem::uninitialized

cc rust-lang#62397
r? @RalfJung
bors added a commit that referenced this pull request Jul 6, 2019
Rollup of 5 pull requests

Successful merges:

 - #60081 (Refactor unicode.py script)
 - #61862 (Make the Weak::{into,as}_raw methods)
 - #62243 (Improve documentation for built-in macros)
 - #62422 (Remove some uses of mem::uninitialized)
 - #62436 (normalize use of backticks/lowercase in compiler messages for librustc_mir)

Failed merges:

r? @ghost
@bors bors merged commit 7646d49 into rust-lang:master Jul 7, 2019
@tesuji tesuji deleted the remove-some-mem-uinit branch July 7, 2019 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants