Closed
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Contributor
Author
|
@bors try |
Collaborator
bors
added a commit
that referenced
this pull request
Jun 23, 2019
[do not merge] Test mimalloc r? @ghost
Collaborator
|
💔 Test failed - checks-travis |
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
bors
added
the
S-waiting-on-author
Zoxc
force-pushed
the
mimalloc
branch
2 times, most recently
from
43278f0 to
6832643
Compare
Contributor
Author
|
@bors try |
Collaborator
|
🔒 Merge conflict This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message |
Contributor
Author
|
@bors try |
Collaborator
bors
added a commit
that referenced
this pull request
Jun 24, 2019
[do not merge] Test mimalloc r? @ghost
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Collaborator
|
☀️ Try build successful - checks-travis |
Contributor
Author
|
@rust-timer build 090f4a4 |
Collaborator
|
Success: Queued 090f4a4 with parent 85ed21e, comparison URL. |
Collaborator
|
Finished benchmarking try commit 090f4a4, comparison URL. |
Contributor
|
No change :( Maybe updating your fork to include gnzlbg/mimallocator@4c47b66 could improve performance? (not sure that would be noticeable though) |
Contributor
Author
|
It seems like a minor win. Applying it to LLVM and inlining the fast paths could improve things further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @ghost