const fn: Improve wording by JohnTitor · Pull Request #59646 · rust-lang/rust

JohnTitor · 2019-04-02T21:46:00Z

This might need discussion. Feel free to close this PR if we don't need to fix.

rust-highfive · 2019-04-02T21:46:04Z

(rust_highfive has picked a reviewer for you, use r? to override)

varkor · 2019-04-02T23:03:24Z

                    abi::Abi::Rust => return Err((
                        span,
-                        "can only call other `min_const_fn` within a `min_const_fn`".into(),
+                        "can only call other `const` within a `const`".into(),


Something like can only call another `const fn` within a `const` block sounds more natural.

Neither this PR nor the suggestion is accurate. This is not a const block (and with rust-lang/rfcs#2632 it will not always behave in a similar fashion).

Moreover, I think we lose out on the difference between stable const fns and unstable ones. This is the main point of min_const_fns... I think we should check whether the current compiler can use unstable features and tweak the message based on that. E.g. a stable compiler can just talk about const fns but the nightly compiler should emphasize the difference between stable and unstable ones.

Maybe change it to

can only call other stable `const fn` within a stable `const fn`

?

Ah, in that case we should make the error more explicit and add a note to the unstable const fn pointing out that it is undertake.

That is, it's not clear whether it's the containing function or the called function that is the problem (or both).

The problem is to be used same wording without distinction, I think. Should we try to work on this?

kinda both. I'm not sure how easy it is to point to the unstable const fn, since it might be in another crate. We can just use a more verbose wording like

can only call other const fn within a const fn, but insert_fn_name_here is not stable as const fn

@oli-obk I changed wording.

Centril · 2019-04-02T23:44:09Z

r? @oli-obk

Dylan-DPC-zz · 2019-04-15T18:33:15Z

ping from triage @oli-obk any updates?

oli-obk · 2019-04-16T07:55:56Z

@bors r+ rollup

bors · 2019-04-16T07:55:57Z

📌 Commit 4075415 has been approved by oli-obk

bors · 2019-04-17T02:03:26Z

⌛ Testing commit 4075415 with merge 7f83a069569be0fbed78b108abecc2894bfa63d1...

bors · 2019-04-17T04:10:07Z

💔 Test failed - checks-travis

rust-highfive · 2019-04-17T04:10:09Z

The job dist-i586-gnu-i586-i686-musl of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[01:34:17] test iter::test_double_ended_range ... ok
[01:34:17] test iter::test_filter_try_folds ... ok
[01:34:17] test iter::test_find_map ... ok
[01:34:17] test iter::test_filter_map_fold ... ok
No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Centril · 2019-04-17T04:36:27Z

@bors retry

const fn: Improve wording fixes rust-lang#59611 This might need discussion. Feel free to close this PR if we don't need to fix.

@ghost

Rollup of 5 pull requests Successful merges: - #59128 (Emit ansi color codes in the `rendered` field of json diagnostics) - #59646 (const fn: Improve wording) - #59986 (Miri: refactor new allocation tagging) - #60003 (LLD is not supported on Darwin) - #60018 (Miri now supports entropy, but is still slow) Failed merges: r? @ghost

Improve wording

ae2ed21

rust-highfive assigned davidtwco Apr 2, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 2, 2019

varkor reviewed Apr 2, 2019

View reviewed changes

rust-highfive assigned oli-obk and unassigned davidtwco Apr 2, 2019

JohnTitor added 2 commits April 16, 2019 07:32

Make wording verbose

dce86f9

Fix tests

4075415

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2019

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 17, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 17, 2019

Centril added a commit to Centril/rust that referenced this pull request Apr 17, 2019

Rollup merge of rust-lang#59646 - JohnTitor:improve-wording, r=oli-obk

0349b78

const fn: Improve wording fixes rust-lang#59611 This might need discussion. Feel free to close this PR if we don't need to fix.

Centril mentioned this pull request Apr 17, 2019

Rollup of 5 pull requests #60030

Merged

bors merged commit 4075415 into rust-lang:master Apr 17, 2019

JohnTitor deleted the improve-wording branch April 17, 2019 15:45

Uh oh!

Conversation

JohnTitor commented Apr 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Apr 2, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Centril commented Apr 2, 2019

Uh oh!

Dylan-DPC-zz commented Apr 15, 2019

Uh oh!

oli-obk commented Apr 16, 2019

Uh oh!

bors commented Apr 16, 2019

Uh oh!

bors commented Apr 17, 2019

Uh oh!

bors commented Apr 17, 2019

Uh oh!

rust-highfive commented Apr 17, 2019

Uh oh!

Centril commented Apr 17, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

JohnTitor commented Apr 2, 2019 •

edited

Loading