Optimize Vec's IntoIter's methods#57246
Closed
czipperz wants to merge 1 commit intorust-lang:masterfrom
Closed
Conversation
Contributor
|
r? @bluss (rust_highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
067e9ba to
59755d6
Compare
59755d6 to
3e8fbd8
Compare
Contributor
|
Have you benchmarked these changes? |
Contributor
Author
|
Related to #57245 (comment), I think this change would cause side effects in destructors to trigger in different orders and thus not be backwards compatible. |
Contributor
Author
|
To directly address your comment @varkor, these changes would take |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In particular
nthandlast. To do: implementnth_back.