Skip to content

NLL is missing struct field suggestion#54831

Merged
bors merged 2 commits intorust-lang:masterfrom
davidtwco:issue-52663-struct-field-suggestion
Oct 10, 2018
Merged

NLL is missing struct field suggestion#54831
bors merged 2 commits intorust-lang:masterfrom
davidtwco:issue-52663-struct-field-suggestion

Conversation

@davidtwco
Copy link
Copy Markdown
Member

Part of #52663.

This commit adds suggestions to change the definitions of fields in
struct definitions from immutable references to mutable references.

r? @nikomatsakis
cc @pnkfelix

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 4, 2018
Comment thread src/librustc_mir/borrow_check/mutability_errors.rs Outdated
Comment thread src/test/ui/did_you_mean/issue-38147-2.nll.stderr Outdated
@davidtwco davidtwco force-pushed the issue-52663-struct-field-suggestion branch from e15c946 to f0b457e Compare October 5, 2018 12:49
Copy link
Copy Markdown
Contributor

@nikomatsakis nikomatsakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me but maybe consider matching AST message (could we then remove the .nll reference?)

Comment thread src/test/ui/did_you_mean/issue-38147-2.nll.stderr Outdated
@memoryruins memoryruins added the A-NLL Area: Non-lexical lifetimes (NLL) label Oct 6, 2018
Comment thread src/librustc_mir/borrow_check/mutability_errors.rs Outdated
This commit adds suggestions to change the definitions of fields in
struct definitions from immutable references to mutable references.
This commit changes the label to a maybe incorrect suggestion for better
integration with RLS.
@davidtwco davidtwco force-pushed the issue-52663-struct-field-suggestion branch from f0b457e to 9e49ac0 Compare October 8, 2018 10:27
@nikomatsakis
Copy link
Copy Markdown
Contributor

@bors r+

@bors
Copy link
Copy Markdown
Collaborator

bors commented Oct 8, 2018

📌 Commit 9e49ac0 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 8, 2018
emilyalbini added a commit to emilyalbini/rust that referenced this pull request Oct 9, 2018
…suggestion, r=nikomatsakis

NLL is missing struct field suggestion

Part of rust-lang#52663.

This commit adds suggestions to change the definitions of fields in
struct definitions from immutable references to mutable references.

r? @nikomatsakis
cc @pnkfelix
@bors
Copy link
Copy Markdown
Collaborator

bors commented Oct 10, 2018

⌛ Testing commit 9e49ac0 with merge 71d3a71...

bors added a commit that referenced this pull request Oct 10, 2018
… r=nikomatsakis

NLL is missing struct field suggestion

Part of #52663.

This commit adds suggestions to change the definitions of fields in
struct definitions from immutable references to mutable references.

r? @nikomatsakis
cc @pnkfelix
@bors
Copy link
Copy Markdown
Collaborator

bors commented Oct 10, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 71d3a71 to master...

@bors bors merged commit 9e49ac0 into rust-lang:master Oct 10, 2018
@davidtwco davidtwco deleted the issue-52663-struct-field-suggestion branch October 10, 2018 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-NLL Area: Non-lexical lifetimes (NLL) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants