Move some compile-fail tests to ui#52409
Conversation
There was a problem hiding this comment.
The deleted files (such as this one) are moves with changes.
There was a problem hiding this comment.
why were they changed?
and why in a single commit? 😢
There was a problem hiding this comment.
I had to add the error note check, as they were relying only on regex matching the output. I couldn't tell in advance whether a given test would need to be changed before running them as ui. I can rewrite the commit history to do so later.
|
r? @oli-obk |
This comment has been minimized.
This comment has been minimized.
oli-obk
left a comment
There was a problem hiding this comment.
r=me with travis passing, no need to block on these comments. Just address them in a follow up. This PR will bitrot too fast otherwise
There was a problem hiding this comment.
this is not needed anymore
There was a problem hiding this comment.
that comment is weird. no explanation and the file does have a trailing newline, altough not a full extra empty line at the end
There was a problem hiding this comment.
to be fair, the name of the file does lead us to #11493, which explicitly said that to reproduce the bug in question, we needed to have a file with no trailing newline...
There was a problem hiding this comment.
Open an issue about this wrong suggestion
There was a problem hiding this comment.
this should probably be a // compile-pass test
There was a problem hiding this comment.
This span is weird and the message is inverted. Should probably also open an issue about it
There was a problem hiding this comment.
this could have a structured suggestion
There was a problem hiding this comment.
another suggestion would be to manually expand to x = x + y if a bound for Add is there
|
Thank you for the thorough checking of the output! That's part of why I wanted to move to |
|
@bors r=oli-obk p=10 |
|
📌 Commit 2332759 has been approved by |
|
⌛ Testing commit 2332759 with merge c2735d26cc9ae5b42d11af7d8f080fec8aa84bfb... |
|
💔 Test failed - status-travis |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
@bors r+ p=10 |
|
📌 Commit f760960 has been approved by |
|
@bors r- |
|
@bors r=oli-obk p=10 |
|
📌 Commit f760960 has been approved by |
Details |
|
@bors r=oli-obk p=10 |
|
📌 Commit e0b54b5411a286f16ad89a10684dc42daa1750ec has been approved by |
|
⌛ Testing commit e0b54b5411a286f16ad89a10684dc42daa1750ec with merge 89c20aef0cb1552111fe1b549b193b905240ab13... |
|
💔 Test failed - status-travis |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
1 similar comment
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
@bors r+ p=10 |
|
📌 Commit 82fd8d7 has been approved by |
Move some `compile-fail` tests to `ui` Re: #44844.
|
☀️ Test successful - status-appveyor, status-travis |
Re: #44844.